Skip to content

o/certstate: add new helper functions to manipulate custom certificate#16684

Open
Meulengracht wants to merge 1 commit intocanonical:masterfrom
Meulengracht:feature/certstate-api-update
Open

o/certstate: add new helper functions to manipulate custom certificate#16684
Meulengracht wants to merge 1 commit intocanonical:masterfrom
Meulengracht:feature/certstate-api-update

Conversation

@Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented Feb 27, 2026

Split from #16486. Introduces new helper functions to manage custom certificates and retrieve them again.

@github-actions github-actions bot added the Run only one system Only runs spread tests on one system label Feb 27, 2026
@Meulengracht Meulengracht marked this pull request as ready for review February 27, 2026 09:12
@github-actions github-actions bot removed the Run only one system Only runs spread tests on one system label Feb 27, 2026
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Fri Feb 27 10:37:13 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/22479966080

Failures:

Executing:

  • openstack:debian-12-64:tests/main/cgroup-devices-v2
  • openstack:ubuntu-core-20-64:tests/core/kernel-base-gadget-pair-single-reboot-failover:kernel_base
  • openstack:ubuntu-core-24-64:tests/main/default-tracks

Restoring:

  • openstack:ubuntu-core-18-64:tests/main/interfaces-system-dbus
  • openstack:ubuntu-core-20-64:tests/core/kernel-base-gadget-pair-single-reboot-failover:kernel_base
  • openstack:ubuntu-core-20-64:tests/core/
  • openstack:ubuntu-core-20-64:

Skipped tests from snapd-testing-skip

  • openstack:ubuntu-24.04-64:tests/main/i18n

// /var/lib/snapd/pki/v1/merged/*.crt (symlinks)
// /var/lib/snapd/pki/v1/merged/ca-certificates.crt
// /var/lib/snapd/pki/v1/<digest>.crt
// /var/lib/snapd/pki/v1/<name>.crt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semantic change based on a quick sync with @pedronis -- the specification has been updated to reflect this

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 73.19588% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.53%. Comparing base (53aa68a) to head (cf67354).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
overlord/certstate/certs.go 73.19% 18 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16684      +/-   ##
==========================================
+ Coverage   77.52%   77.53%   +0.01%     
==========================================
  Files        1354     1358       +4     
  Lines      186672   187410     +738     
  Branches     2449     2446       -3     
==========================================
+ Hits       144714   145314     +600     
- Misses      33205    33312     +107     
- Partials     8753     8784      +31     
Flag Coverage Δ
unittests 77.53% <73.19%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant